Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out for remaining args in custom commands #886

Merged
merged 1 commit into from
Aug 20, 2014

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Aug 20, 2014

If a user provides additional args that a custom command has not declared in the arg table, we should error out with an unknown options error message like we do for built in commands.

There was also a small change in the new line output for the builtin command case so that we have the exact same output in both cases:

$ aws s3api list-objects --bucket foo --extra-argument-foo

Unknown options: --extra-argument-foo

$ aws s3 ls --extra-argument-foo

Unknown options: --extra-argument-foo

cc @danielgtaylor @kyleknap

@kyleknap
Copy link
Contributor

LGTM

@danielgtaylor
Copy link
Contributor

LGTM 🚢-it!

@jamesls jamesls merged commit 4d93057 into aws:develop Aug 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants